A TSServer implementation that just uses the files list to avoid looking all over the file system. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Jun 9, 2017
src/server/project.ts
Outdated
| @@ -202,7 +202,93 @@ namespace ts.server { | |||
|
|
|||
| this.setInternalCompilerOptionsForEmittingJsFiles(); | |||
|
|
|||
| this.lsHost = new LSHost(this.projectService.host, this, this.projectService.cancellationToken); | |||
| let proxyHost:ServerHost = (<any>Object).assign({}, this.projectService.host); | |||
| if (projectKind === ProjectKind.Configured && hasExplicitListOfFiles) { | |||
There was a problem hiding this comment.
where does hasExplicitListOfFiles come from?
There was a problem hiding this comment.
It's a constructor parameter to the Project from the ProjectService that creates it.
vikerman
force-pushed
the
g3
branch
2 times, most recently
from
3cede8f to
dd0b3c7
Compare
vikerman
force-pushed
the
g3
branch
3 times, most recently
from
f45b666 to
c8561e5
Compare
…ing all over the file system. Improves performance when running on a network file system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance when running on a network file system.